fix: Post one "Like" activity with multiple URIs in "to" field #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of posting two "Like" activities, post one activity with multiple URIs in the "to" field. Also: - Fix the WebFinger CAS query to return 400 (bad request) instead of 500 in the CID isn't in the request. - Added more logging in BDD test to also log the error message. Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
Codecov Report
@@ Coverage Diff @@
## main #787 +/- ##
==========================================
+ Coverage 89.92% 89.93% +0.01%
==========================================
Files 140 139 -1
Lines 11864 11856 -8
==========================================
- Hits 10669 10663 -6
+ Misses 737 736 -1
+ Partials 458 457 -1
Continue to review full report at Codecov.
|
sandrask
approved these changes
Sep 22, 2021
fqutishat
approved these changes
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of posting two "Like" activities, post one activity with multiple URIs in the "to" field.
Also:
Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com